NO TICKET: near-universal adoption of release_status and created_at | complete implementation of active_location for the /thing router | async coverage for all endpoints#117
Merged
Conversation
And test to ensure created_at in all responses
Codecov Report✅ All modified and coverable lines are covered by tests.
|
jirhiker
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
created_atfield/lexiconrouter, should have arelease_statusfield/lexiconrouter, should requirerelease_statusto be filled/lexiconrouter, should allowrelease_statusto be edited/thingrouter should include anactive_locationfieldasyncHow
Implementation summary - the following was changed / added / removed:
ReleaseMixinto all database models where it was previously absent, except forLexiconmodelsBaseCreateModel,BaseUpdateModel, andBaseResponseModelin/schemas/__init__.pyto enable universal fields to be present for all relevant modelsid,created_at, andrelease_statuswhere appropriatetests/test_thing.pyforactive_locationNotes
Any special considerations, workarounds, or follow-up work to note?
create_contactwas made more flexible for future model/schema changes